Repository navigation
test: certify Cloudflare R2-first and GitHub fallback behavior - #187
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Certify the intended Zed artifact retrieval order end to end:
/github/*proxy when the R2 copy is unavailable;This PR:
zed-pkg/zed-infraCDN Worker at immutable commit2150c08b94ae64bb6a30ef7d2465462b6d65cd48;artifacts/<sha>R2 hit returns exact bytes withx-zed-source: r2and performs no upstream fetch;/github/<owner>/<repo>/<tag>/<file>request is proxied by Cloudflare through an allowlisted GitHub redirect chain withx-zed-source: github-release;zed-infraexplicitly for workflow-call/dispatch certification and documents the private-R2/public-proxy security boundary.The locator correction consumed by the candidate CLI is in
zed-pkg/zed-interfaces#105.Why
The previous canary copied all guessable paths into a static HTTP directory and proved only that some CDN fallback restored the package. It neither executed the real Cloudflare Worker nor distinguished an R2 hit from the
/github/*proxy path. That allowed source-precedence drift to go undetected./github/*is intentionally a credential-free Cloudflare proxy, not a private-bucket read oracle. Direct R2 access remains limited to immutableartifacts/<sha>objects and signed metadata.Verification
Completed on the branch:
python3 -m py_compile scripts/github_r2_fallback.py;node --check scripts/cloudflare_github_fallback_contract.mjs;git diff --check;r2, fallback sourcegithub-release, allowlisted upstream hosts only.The reusable full lane additionally builds an exact CLI/interface tuple, checks interface/client/lib-core contracts, executes the Worker contract, and runs the three-phase frozen-install canary. The exact candidate tuple will be supplied after the focused
zed-clipin finishes validation.No credentials, production buckets, package publication, deployment, token mutation, or public redirect behavior are involved.